- GiNaC-devel - ginac.de

[SCM] GiNaC -- a C++ library for symbolic computations branch, master, updated. release_1-4-0-197-g59ec138
by git＠ginac.de 09 Aug '09

09 Aug '09

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GiNaC -- a C++ library for symbolic computations". The branch, master has been updated via 59ec13895c97ffd74979a0b811a7571f6de56386 (commit) via 694f839947982f5b12b6c629d5bab522c801630d (commit) via 526825bcee294cb20e37d8db6d5040ba0f8c428f (commit) via 49a44f7d55ec0d6686d3c32c7081a07d10c93274 (commit) via dda45abd8a2c408f8b3eb7959a10dfb2468ecc3a (commit) from 619879b5bd86a99334affe1f05d17616cc2c1898 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 59ec13895c97ffd74979a0b811a7571f6de56386 Author: Alexei Sheplyakov <varg(a)metalica.kh.ua> Date: Sat Aug 8 13:03:15 2009 +0300 modular_matrix: don't use STL iterators in {mul, sub}_col and friends. Not using STL iterators makes the code simpler and cleaner. Also we don't have to argue whether the standard ([lib.random.access.iterators]) imposes any pre/post-condictions on operator+=. commit 694f839947982f5b12b6c629d5bab522c801630d Author: Alexei Sheplyakov <varg(a)metalica.kh.ua> Date: Sat Aug 8 13:03:48 2009 +0300 shaker_sort, permutation_sign: fix invalid use of STL iterators. According to the standard incrementing end(), and decrementing begin() are ill-defined operations (see [lib.forward.iterators], [lib.bidirectional.iterators]). commit 526825bcee294cb20e37d8db6d5040ba0f8c428f Author: Alexei Sheplyakov <varg(a)metalica.kh.ua> Date: Sat Aug 8 13:07:14 2009 +0300 symmetry::calchash(): be careful to not dereference past-the-end iterator. commit 49a44f7d55ec0d6686d3c32c7081a07d10c93274 Author: Alexei Sheplyakov <varg(a)metalica.kh.ua> Date: Sat Aug 8 13:06:36 2009 +0300 check_parameter_G: fix pontential increment of end(). Incrementing past-the-end iterator is not permitted by the standard, see [lib.input.iterators]. commit dda45abd8a2c408f8b3eb7959a10dfb2468ecc3a Author: Alexei Sheplyakov <varg(a)metalica.kh.ua> Date: Sat Aug 8 13:02:47 2009 +0300 G_eval: fix incorrect use of STL iterator. According to [lib.bidirectional.iterators] it's not OK to decrement an iterator pointing to the beginning of the sequence. Fortunately random access iterators provided by (current versions of) gcc/libstdc++ don't have this silly limitation, so the code which works with pointers works with iterators without any changes at all. However, - there's no guarantee that the current behavior won't change in the future - some non-GNU compilers are not that smart (i.e. the program segfaults upon when decrementing beginning-of-the-sequence iterator). ----------------------------------------------------------------------- Summary of changes: ginac/factor.cpp | 60 +++++++++++++++++--------------------------- ginac/inifcns_nstdsums.cpp | 7 +++- ginac/symmetry.cpp | 3 +- ginac/utils.h | 24 +++++++++++++---- 4 files changed, 48 insertions(+), 46 deletions(-) hooks/post-receive -- GiNaC -- a C++ library for symbolic computations

1 0

[SCM] GiNaC -- a C++ library for symbolic computations branch, ginac_1-5, updated. release_1-4-0-198-g8bf0597
by git＠ginac.de 08 Aug '09

08 Aug '09

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GiNaC -- a C++ library for symbolic computations". The branch, ginac_1-5 has been updated via 8bf0597dde55e4c94a2ff39f1d8130902e3d7a9b (commit) via eaf81b3115697a8e883848ace0ceb919cf443b2c (commit) from eb192338b3abd1252523a013a4f924ee38b10039 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8bf0597dde55e4c94a2ff39f1d8130902e3d7a9b Author: Jens Vollinga <jensv(a)balin.nikhef.nl> Date: Fri Jul 31 12:48:58 2009 +0200 Fixed the parser such that it can read in user defined classes again. Fixed default reader to parse also pow, sqrt and power. commit eaf81b3115697a8e883848ace0ceb919cf443b2c Author: Jens Vollinga <jensv(a)balin.nikhef.nl> Date: Fri Jul 31 11:14:01 2009 +0200 Fixed cast that caused compile error on 64bit machines. ----------------------------------------------------------------------- Summary of changes: ginac/function.pl | 3 ++ ginac/parser/builtin_fcns.def | 76 --------------------------------------- ginac/parser/default_reader.tpl | 5 +++ ginac/parser/parser.cpp | 12 +++++- 4 files changed, 18 insertions(+), 78 deletions(-) hooks/post-receive -- GiNaC -- a C++ library for symbolic computations

4 11

[PATCH 4/6] symmetry::calchash(): be careful to not dereference past-the-end iterator.
by Alexei Sheplyakov 08 Aug '09

08 Aug '09

--- ginac/symmetry.cpp | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/ginac/symmetry.cpp b/ginac/symmetry.cpp index 9e00a8c..725506f 100644 --- a/ginac/symmetry.cpp +++ b/ginac/symmetry.cpp @@ -190,7 +190,8 @@ unsigned symmetry::calchash() const if (type == none) { v = rotate_left(v); - v ^= *(indices.begin()); + if (!indices.empty()) + v ^= *(indices.begin()); } else { for (exvector::const_iterator i=children.begin(); i!=children.end(); ++i) { -- 1.6.3.3

1 0

[PATCH 2/6] check_parameter_G: fix pontential increment of end().
by Alexei Sheplyakov 08 Aug '09

08 Aug '09

Incrementing past-the-end iterator is not permitted by the standard, see [lib.input.iterators]. --- ginac/inifcns_nstdsums.cpp | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ginac/inifcns_nstdsums.cpp b/ginac/inifcns_nstdsums.cpp index b410533..11a91dd 100644 --- a/ginac/inifcns_nstdsums.cpp +++ b/ginac/inifcns_nstdsums.cpp @@ -659,6 +659,8 @@ Gparameter::const_iterator check_parameter_G(const Gparameter& a, int scale, ++trailing_zeros; } } + if (lastnonzero == a.end()) + return a.end(); return ++lastnonzero; } -- 1.6.3.3

1 0

[PATCH 6/6] shaker_sort, permutation_sign: fix invalid use of STL iterators.
by Alexei Sheplyakov 08 Aug '09

08 Aug '09

According to the standard incrementing end(), and decrementing begin() are ill-defined operations (see [lib.forward.iterators], [lib.bidirectional.iterators]). --- ginac/utils.h | 24 ++++++++++++++++++------ 1 files changed, 18 insertions(+), 6 deletions(-) diff --git a/ginac/utils.h b/ginac/utils.h index 393c474..e65bdae 100644 --- a/ginac/utils.h +++ b/ginac/utils.h @@ -128,7 +128,9 @@ int permutation_sign(It first, It last) sign = -sign; } else if (!(*other < *i)) return 0; - --i; --other; + --i; + if (i != first) + --other; } if (!swapped) return sign; @@ -147,7 +149,9 @@ int permutation_sign(It first, It last) sign = -sign; } else if (!(*i < *other)) return 0; - ++i; ++other; + ++i; + if (i != last) + ++other; } if (!swapped) return sign; @@ -181,7 +185,9 @@ int permutation_sign(It first, It last, Cmp comp, Swap swapit) sign = -sign; } else if (!comp(*other, *i)) return 0; - --i; --other; + --i; + if (i != first) + --other; } if (!swapped) return sign; @@ -200,7 +206,9 @@ int permutation_sign(It first, It last, Cmp comp, Swap swapit) sign = -sign; } else if (!comp(*i, *other)) return 0; - ++i; ++other; + ++i; + if (i != last) + ++other; } if (!swapped) return sign; @@ -232,7 +240,9 @@ void shaker_sort(It first, It last, Cmp comp, Swap swapit) flag = other; swapped = true; } - --i; --other; + --i; + if (i != first) + --other; } if (!swapped) return; @@ -249,7 +259,9 @@ void shaker_sort(It first, It last, Cmp comp, Swap swapit) flag = other; swapped = true; } - ++i; ++other; + ++i; + if (i != last) + ++other; } if (!swapped) return; -- 1.6.3.3

1 0

[PATCH 3/6] modular_matrix: don't use STL iterators in {mul, sub}_col and friends.
by Alexei Sheplyakov 08 Aug '09

08 Aug '09

Not using STL iterators makes the code simpler and cleaner. Also we don't have to argue whether the standard ([lib.random.access.iterators]) imposes any pre/post-condictions on operator+=. --- ginac/factor.cpp | 60 ++++++++++++++++++++--------------------------------- 1 files changed, 23 insertions(+), 37 deletions(-) diff --git a/ginac/factor.cpp b/ginac/factor.cpp index 2f9157b..c82e744 100644 --- a/ginac/factor.cpp +++ b/ginac/factor.cpp @@ -691,90 +691,76 @@ public: cl_MI operator()(size_t row, size_t col) const { return m[row*c + col]; } void mul_col(size_t col, const cl_MI x) { - mvec::iterator i = m.begin() + col; for ( size_t rc=0; rc<r; ++rc ) { - *i = *i * x; - i += c; + std::size_t i = c*rc + col; + m[i] = m[i] * x; } } void sub_col(size_t col1, size_t col2, const cl_MI fac) { - mvec::iterator i1 = m.begin() + col1; - mvec::iterator i2 = m.begin() + col2; for ( size_t rc=0; rc<r; ++rc ) { - *i1 = *i1 - *i2 * fac; - i1 += c; - i2 += c; + std::size_t i1 = col1 + c*rc; + std::size_t i2 = col2 + c*rc; + m[i1] = m[i1] - m[i2]*fac; } } void switch_col(size_t col1, size_t col2) { - cl_MI buf; - mvec::iterator i1 = m.begin() + col1; - mvec::iterator i2 = m.begin() + col2; for ( size_t rc=0; rc<r; ++rc ) { - buf = *i1; *i1 = *i2; *i2 = buf; - i1 += c; - i2 += c; + std::size_t i1 = col1 + rc*c; + std::size_t i2 = col2 + rc*c; + std::swap(m[i1], m[i2]); } } void mul_row(size_t row, const cl_MI x) { - vector<cl_MI>::iterator i = m.begin() + row*c; for ( size_t cc=0; cc<c; ++cc ) { - *i = *i * x; - ++i; + std::size_t i = row*c + cc; + m[i] = m[i] * x; } } void sub_row(size_t row1, size_t row2, const cl_MI fac) { - vector<cl_MI>::iterator i1 = m.begin() + row1*c; - vector<cl_MI>::iterator i2 = m.begin() + row2*c; for ( size_t cc=0; cc<c; ++cc ) { - *i1 = *i1 - *i2 * fac; - ++i1; - ++i2; + std::size_t i1 = row1*c + cc; + std::size_t i2 = row2*c + cc; + m[i1] = m[i1] - m[i2]*fac; } } void switch_row(size_t row1, size_t row2) { - cl_MI buf; - vector<cl_MI>::iterator i1 = m.begin() + row1*c; - vector<cl_MI>::iterator i2 = m.begin() + row2*c; for ( size_t cc=0; cc<c; ++cc ) { - buf = *i1; *i1 = *i2; *i2 = buf; - ++i1; - ++i2; + std::size_t i1 = row1*c + cc; + std::size_t i2 = row2*c + cc; + std::swap(m[i1], m[i2]); } } bool is_col_zero(size_t col) const { mvec::const_iterator i = m.begin() + col; for ( size_t rr=0; rr<r; ++rr ) { - if ( !zerop(*i) ) { + std::size_t i = col + rr*c; + if ( !zerop(m[i]) ) { return false; } - i += c; } return true; } bool is_row_zero(size_t row) const { - mvec::const_iterator i = m.begin() + row*c; for ( size_t cc=0; cc<c; ++cc ) { - if ( !zerop(*i) ) { + std::size_t i = row*c + cc; + if ( !zerop(m[i]) ) { return false; } - ++i; } return true; } void set_row(size_t row, const vector<cl_MI>& newrow) { - mvec::iterator i1 = m.begin() + row*c; - mvec::const_iterator i2 = newrow.begin(), end = newrow.end(); - for ( ; i2 != end; ++i1, ++i2 ) { - *i1 = *i2; + for (std::size_t i2 = 0; i2 < newrow.size(); ++i2) { + std::size_t i1 = row*c + i2; + m[i1] = newrow[i2]; } } mvec::const_iterator row_begin(size_t row) const { return m.begin()+row*c; } -- 1.6.3.3

1 0

[PATCH 1/6] G_eval: fix incorrect use of STL iterator.
by Alexei Sheplyakov 08 Aug '09

08 Aug '09

According to [lib.bidirectional.iterators] it's not OK to decrement an iterator pointing to the beginning of the sequence. Fortunately random access iterators provided by (current versions of) gcc/libstdc++ don't have this silly limitation, so the code which works with pointers works with iterators without any changes at all. However, - there's no guarantee that the current behavior won't change in the future - some non-GNU compilers are not that smart (i.e. the program segfaults upon when decrementing beginning-of-the-sequence iterator). --- ginac/inifcns_nstdsums.cpp | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/ginac/inifcns_nstdsums.cpp b/ginac/inifcns_nstdsums.cpp index 2c4061a..b410533 100644 --- a/ginac/inifcns_nstdsums.cpp +++ b/ginac/inifcns_nstdsums.cpp @@ -569,11 +569,12 @@ ex G_eval(const Gparameter& a, int scale, const exvector& gsyms) Gparameter newa; Gparameter::const_iterator it2 = short_a.begin(); - for (--it2; it2 != it;) { - ++it2; + for (; it2 != it; ++it2) { newa.push_back(*it2); } + newa.push_back(*it); newa.push_back(a[0]); + it2 = it; ++it2; for (; it2 != short_a.end(); ++it2) { newa.push_back(*it2); -- 1.6.3.3

1 0

Debian files in git repository
by Richard B. Kreckel 04 Aug '09

04 Aug '09

Hi, I suppose nobody really cares about the debian/ directory. The files in there have not been maintained well, lately. Of course, this is because their lifecycle is better maintained over with the Debian packages. Anybody who cares about these files knows where they are: they are contained in the ginac_*.diff.gz files in the Debian package pool. Unless somebody speaks up, I will remove them from the repository, soon. Cheers -richy. -- Richard B. Kreckel <http://www.ginac.de/~kreckel/>

2 2

[SCM] GiNaC -- a C++ library for symbolic computations branch, master, updated. release_1-4-0-191-gf38cbcd
by git＠ginac.de 04 Aug '09

04 Aug '09

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GiNaC -- a C++ library for symbolic computations". The branch, master has been updated via f38cbcd651246fb5c1294705d29399f3cbfddaf5 (commit) via feed241b95f7dbd6294795b4afc2bcae41880c31 (commit) from 71803f13294618ddd3f19fd0d9871cc44023c155 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f38cbcd651246fb5c1294705d29399f3cbfddaf5 Author: Jens Vollinga <jensv(a)nikhef.nl> Date: Fri Jul 10 15:01:04 2009 +0200 Changed the parser such that it understands all defined functions including the user defined ones. To this end a method has been added to class function to allow the modified get_default_reader() function to build up a complete prototype table. The autogen tool is no longer required. commit feed241b95f7dbd6294795b4afc2bcae41880c31 Author: Jens Vollinga <jensv(a)nikhef.nl> Date: Fri Jul 10 09:54:09 2009 +0200 Fixed manual to correctly explain return_type_tinfo(). ----------------------------------------------------------------------- Summary of changes: INSTALL | 3 +- configure.ac | 4 -- doc/tutorial/ginac.texi | 63 ++++++++++++++++----------- ginac/Makefile.am | 18 +------- ginac/function.pl | 1 + ginac/parser/builtin_fcns.def | 90 --------------------------------------- ginac/parser/default_reader.tpl | 50 --------------------- ginac/parser/parse_context.cpp | 20 +++++++++ ginac/parser/parse_context.h | 21 +++------ ginac/parser/parser.cpp | 3 +- 10 files changed, 69 insertions(+), 204 deletions(-) delete mode 100644 ginac/parser/builtin_fcns.def delete mode 100644 ginac/parser/default_reader.tpl hooks/post-receive -- GiNaC -- a C++ library for symbolic computations

4 8

[SCM] GiNaC -- a C++ library for symbolic computations branch, ginac_1-5, updated. release_1-4-0-201-g5252d38
by git＠ginac.de 31 Jul '09

31 Jul '09

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GiNaC -- a C++ library for symbolic computations". The branch, ginac_1-5 has been updated via 5252d38313c423465b9bc37b0618cb8de96d0d4e (commit) from 7a092f6f6256bac2e5b7c35222fe7e18ca980401 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5252d38313c423465b9bc37b0618cb8de96d0d4e Author: Jens Vollinga <jensv(a)balin.nikhef.nl> Date: Fri Jul 31 17:54:16 2009 +0200 Fixed memory leak. ----------------------------------------------------------------------- Summary of changes: ginac/parser/parser.cpp | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) hooks/post-receive -- GiNaC -- a C++ library for symbolic computations

1 0