- GiNaC-devel - ginac.de

GiNaC releases 1.3.9 and 1.4.1
by Jens Vollinga 21 Nov '07

21 Nov '07

Hello everybody, GiNaC 1.4.1 is out and available. The changes are: * Fixed memory leak in ginac_yylex(). * Fixed memory leaks in mul::eval() and power::eval(). * Fixed macro checking for version of libreadline (Mac OS X). * Fixed broken preprocessor instruction in excompiler.cpp. * Fixed broken module loading in excompiler.cpp. * info(info_flags::has_indices) now works for sums and products. * Improved mul::expand(). * Improved CLN output. As always, this release can be downloaded from http://www.ginac.de/Download.html We also made a backporting bug-fix release for the GiNaC 1.3.x series, which contains the following changes: * Fixed memory leak in ginac_yylex(). * Fixed memory leaks in mul::eval() and power::eval(). * Fixed macro checking for version of libreadline (Mac OS X). * info(info_flags::has_indices) now works for sums and products. * Improved CLN output. This package can be downloaded from the ftp server: ftp://ftpthep.physik.uni-mainz.de/pub/GiNaC/ Best wishes, Jens

1 0

Re: [GiNaC-cvs] check parser_memleak.cpp
by Alexei Sheplyakov 21 Nov '07

21 Nov '07

Hi! On Tue, Nov 20, 2007 at 11:19:50PM +0100, CVS Service wrote: > Update of /home/cvs/GiNaC/check by vollinga > > Added Files: > parser_memleak.cpp > Log Message: > Added small program that exhibits the memory leak in the ginac_yylex() [Sheplyakov]. The patch got slightly corrupted ("x2" is wrong, it should be "x^2", as here: http://www.ginac.de/pipermail/ginac-devel/2007-November/001264.html) Please apply this fix diff --git a/check/parser_memleak.cpp b/check/parser_memleak.cpp index ebc6ed9..f347ce9 100644 --- a/check/parser_memleak.cpp +++ b/check/parser_memleak.cpp @@ -18,7 +18,7 @@ int main(int argc, char** argv) { const symbol x("x"), y("y"); const lst syms(x, y); // parser-generated symbol => memory leak. - static const char* str[] = { "x2+2*x*y + cos(x)", "Li2(x/y) + log(y/x)" }; + static const char* str[] = { "x^2+2*x*y + cos(x)", "Li2(x/y) + log(y/x)" }; // depends on the amount of the available VM, compiler options, etc. const unsigned N_max = 500000; Best regards, Alexei -- All science is either physics or stamp collecting.

1 0

Upcoming release
by Jens Vollinga 20 Nov '07

20 Nov '07

Hi, I think I have done all patches now. For tomorrow evening I plan to do the releases 1.3.9 and 1.4.1. Regards, Jens

1 0

bugfix-only release?
by Alexei Sheplyakov 20 Nov '07

20 Nov '07

Hi! Since two serious bugs have been fixed, it would be nice to make a bugfix-only release (1.3.9 and 1.4.1). If anyone has objections, or some patches, or problems/issues to be resolved first, please let me know. Best regards, Alexei -- All science is either physics or stamp collecting.

2 3

[PATCH] Constructing expression from a string does not leak memory any more.
by Alexei Sheplyakov 18 Nov '07

18 Nov '07

Thanks to valgrind for spotting this. --- check/parser_memleak.cpp | 36 ++++++++++++++++++++++++++++++++++++ ginac/input_lexer.ll | 4 +++- 2 files changed, 39 insertions(+), 1 deletions(-) create mode 100644 check/parser_memleak.cpp diff --git a/check/parser_memleak.cpp b/check/parser_memleak.cpp new file mode 100644 index 0000000..f347ce9 --- /dev/null +++ b/check/parser_memleak.cpp @@ -0,0 +1,36 @@ +/** + * This small program exhibits the memory leak in the ginac_yylex(). + * Run it as + * + * valgrind --leak-check=yes ./parser_memleak + * + * or simply + * + * ulimit -v `expr 64 \* 1024` ./parser_memleak + */ +#include <iostream> +#include <stdexcept> +#include <ginac/ginac.h> +using namespace std; +using namespace GiNaC; + +int main(int argc, char** argv) { + const symbol x("x"), y("y"); + const lst syms(x, y); + // parser-generated symbol => memory leak. + static const char* str[] = { "x^2+2*x*y + cos(x)", "Li2(x/y) + log(y/x)" }; + + // depends on the amount of the available VM, compiler options, etc. + const unsigned N_max = 500000; + unsigned N=0; + ex e; + try { + for (; N < N_max; N++) { + e = ex(str[N & 1], syms); + } + } catch (std::bad_alloc) { + cerr << "N = " << N << endl; + return 1; + } + return 0; +} diff --git a/ginac/input_lexer.ll b/ginac/input_lexer.ll index f931394..bc568ce 100644 --- a/ginac/input_lexer.ll +++ b/ginac/input_lexer.ll @@ -119,7 +119,9 @@ Digits ginac_yylval = (long)Digits; return T_DIGITS; {A}{AN}* { sym_tab::const_iterator i = syms.find(yytext); if (i == syms.end()) { - syms[yytext] = sym_def(ginac_yylval = *(new symbol(yytext)), false); + symbol tmp(yytext); + ginac_yylval = tmp; + syms[yytext] = sym_def(tmp, false); } else ginac_yylval = (*i).second.sym; return T_SYMBOL; -- 1.5.3.2 Best regards, Alexei -- All science is either physics or stamp collecting.

1 0

[PATCH] Fix memory leaks in mul::eval() and power::eval() (GiNaC 1.4, HEAD)
by Alexei Sheplyakov 17 Nov '07

17 Nov '07

The bug was introduced by the patch commit f418c6ee4d558c852e1fb95533af07a3ae43f409 Author: Alexei Sheplyakov <varg(a)theor.jinr.ru> Date: Wed Jul 11 14:34:42 2007 +0400 (it was commited into the official branch as commit a602d34c225dceb3e53742a7b3e19a4b5e280485 Author: Jens Vollinga <vollinga(a)thep.physik.uni-mainz.de> Date: Wed Jul 11 21:07:40 2007 +0000) While at it, delete bogus try -- catch block in the ex::series(), since it papers over some serious issues (like this one) and does not seem to do anything useful. Thanks to valgrind (http://valgrind.kde.org) developers for a wonderful piece of software. Debugging this problem would take way too long without it. --- check/mul_eval_memleak.cpp | 119 ++++++++++++++++++++++++++++++++++++++++++++ ginac/mul.cpp | 4 +- ginac/power.cpp | 4 +- ginac/pseries.cpp | 6 +-- 4 files changed, 124 insertions(+), 9 deletions(-) create mode 100644 check/mul_eval_memleak.cpp diff --git a/check/mul_eval_memleak.cpp b/check/mul_eval_memleak.cpp new file mode 100644 index 0000000..78e9312 --- /dev/null +++ b/check/mul_eval_memleak.cpp @@ -0,0 +1,119 @@ +/** + * @file mul_eval_memleak.cpp Test for memory leak in {mul,power}::eval + * + * The bug was introduced by + * + * commit f418c6ee4d558c852e1fb95533af07a3ae43f409 + * Author: Alexei Sheplyakov <varg(a)theor.jinr.ru> + * Date: Wed Jul 11 14:34:42 2007 +0400 + * (it was commited into the official branch as + * commit a602d34c225dceb3e53742a7b3e19a4b5e280485 + * Author: Jens Vollinga <vollinga(a)thep.physik.uni-mainz.de> + * Date: Wed Jul 11 21:07:40 2007 +0000) + */ + +/* + * GiNaC Copyright (C) 1999-2007 Johannes Gutenberg University Mainz, Germany + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include <iostream> +#include <ginac/ginac.h> +#include <string> +#include <stdexcept> +using namespace std; +using namespace GiNaC; + +const unsigned check_mul_eval_memleak(const unsigned N) +{ + // Expanding this expression into a Laurent series triggers the bug. + static const string e_str("\ +1/605927415293858601*tgamma(3-eps)^(-1)*tgamma(2-eps)*(5013234896802\ +*(-1+2*eps)*((-2539001/2)*eps^(-2)+(-7617003/2+1692800*log(920*scale\ +^(-1))+3385202*log(1301*scale^(-1)))*eps^(-1)+F)+(846400+2539001*eps\ +)*(2539001*(-1+2*eps)*((-2539001/2)*eps^(-2)+(-7617003/2+1692800*log\ +(920*scale^(-1))+3385202*log(1301*scale^(-1)))*eps^(-1)+F)+286523497\ +2800*(-1+eps)^(-1)*eps^(-2)*(920*scale^(-1))^(-2*eps)*(1301*scale^(-\ +1))^(-2*eps)*tgamma(1+eps)^2)+6061411748045832000*(-1+eps)^(-1)*eps^\ +(-2)*(920*scale^(-1))^(-2*eps)*(1301*scale^(-1))^(-2*eps)*tgamma(1+e\ +ps)^2+716056132401*((-2539001/2)*eps^(-2)+(-7617003/2+1692800*log(92\ +0*scale^(-1))+3385202*log(1301*scale^(-1)))*eps^(-1)+F))+71656139360\ +0/716056132401*tgamma(1-eps)*tgamma(2*eps)^(-1)*tgamma(eps)^2*tgamma\ +(3-eps)^(-1)*(920*scale^(-1))^(-4*eps)*tgamma(-1+2*eps)-2/6059274152\ +93858601*tgamma(3-eps)^(-1)*(2149010446400*(-1+2*eps)*((-2539001/2)*\ +eps^(-2)+(-7617003/2+1692800*log(920*scale^(-1))+3385202*log(1301*sc\ +ale^(-1)))*eps^(-1)+F)+2425134880977920000*(-1+eps)^(-1)*eps^(-2)*(9\ +20*scale^(-1))^(-2*eps)*(1301*scale^(-1))^(-2*eps)*tgamma(1+eps)^2-7\ +16056132401*((-2539001/2)*eps^(-2)+(-7617003/2+1692800*log(920*scale\ +^(-1))+3385202*log(1301*scale^(-1)))*eps^(-1)+F)+1692601*(-1+2*eps)*\ +(2539001*(-1+2*eps)*((-2539001/2)*eps^(-2)+(-7617003/2+1692800*log(9\ +20*scale^(-1))+3385202*log(1301*scale^(-1)))*eps^(-1)+F)+28652349728\ +00*(-1+eps)^(-1)*eps^(-2)*(920*scale^(-1))^(-2*eps)*(1301*scale^(-1)\ +)^(-2*eps)*tgamma(1+eps)^2))*tgamma(2-eps)+(1/716056132401*I)*tgamma\ +(-1+eps)*mb^2*(mb*scale^(-1))^(-2*eps)*((716392960000*I)*mb^(-2)*(92\ +0*scale^(-1))^(-2*eps)*tgamma(-2+eps)-(2864898145201*I)*mb^(-2)*(130\ +1*scale^(-1))^(-2*eps)*tgamma(-2+eps)-(716224526400*I)*tgamma(-1+eps\ +)*mb^(-2)*(920*scale^(-1))^(-2*eps))-3385202/605927415293858601*tgam\ +ma(3-eps)^(-1)*tgamma(2-eps)*(2539001*(-1+2*eps)*((-2539001/2)*eps^(\ +-2)+(-7617003/2+1692800*log(920*scale^(-1))+3385202*log(1301*scale^(\ +-1)))*eps^(-1)+F)+2865234972800*(-1+eps)^(-1)*eps^(-2)*(920*scale^(-\ +1))^(-2*eps)*(1301*scale^(-1))^(-2*eps)*tgamma(1+eps)^2+846201*((-25\ +39001/2)*eps^(-2)+(-7617003/2+1692800*log(920*scale^(-1))+3385202*lo\ +g(1301*scale^(-1)))*eps^(-1)+F))\ +"); + const symbol eps("eps"), scale("scale"), mb("mb"), F("F"); + const lst syms(eps, scale, mb, F); + const ex e0(e_str, syms); + + unsigned i = 0; + unsigned n_failures = 0; + + ex e; + try { + for (; i < N; i++) + e = e0.series(eps, 1).subs(Euler==0).expand(); + } catch (std::bad_alloc) { + return i; + } + return 0; +} + +#include <sys/types.h> +#include <sys/time.h> +#include <sys/resource.h> +#include <unistd.h> + +static void set_VM_limit(const unsigned long MB) { + const unsigned mem_lim_kb = MB*1024*1024; + struct rlimit lim; + lim.rlim_cur = mem_lim_kb; + lim.rlim_max = mem_lim_kb; + setrlimit(RLIMIT_AS, &lim); +} + +int main(int argc, char** argv) { + static const unsigned max_mem = 32; // megabytes + // otherwise one need wait for a long[er] time. + set_VM_limit(max_mem); + static const unsigned n_of_tests = 10000; + const unsigned n_loops = check_mul_eval_memleak(n_of_tests); + if (n_loops) { + cerr << "memory exhausted after " << n_loops << " loops" << endl; + return 1; + } + return 0; +} + diff --git a/ginac/mul.cpp b/ginac/mul.cpp index 4e95a63..9e1ba48 100644 --- a/ginac/mul.cpp +++ b/ginac/mul.cpp @@ -469,8 +469,8 @@ ex mul::eval(int level) const // XXX: What is the best way to check if the polynomial is a primitive? numeric c = i->rest.integer_content(); - const numeric& lead_coeff = - ex_to<numeric>(ex_to<add>(i->rest).seq.begin()->coeff).div_dyn(c); + const numeric lead_coeff = + ex_to<numeric>(ex_to<add>(i->rest).seq.begin()->coeff).div(c); const bool canonicalizable = lead_coeff.is_integer(); // XXX: The main variable is chosen in a random way, so this code diff --git a/ginac/power.cpp b/ginac/power.cpp index 7d909e8..cbf196f 100644 --- a/ginac/power.cpp +++ b/ginac/power.cpp @@ -505,8 +505,8 @@ ex power::eval(int level) const // (2*x + 6*y)^(-4) -> 1/16*(x + 3*y)^(-4) if (num_exponent->is_integer() && is_exactly_a<add>(ebasis)) { numeric icont = ebasis.integer_content(); - const numeric& lead_coeff = - ex_to<numeric>(ex_to<add>(ebasis).seq.begin()->coeff).div_dyn(icont); + const numeric lead_coeff = + ex_to<numeric>(ex_to<add>(ebasis).seq.begin()->coeff).div(icont); const bool canonicalizable = lead_coeff.is_integer(); const bool unit_normal = lead_coeff.is_pos_integer(); diff --git a/ginac/pseries.cpp b/ginac/pseries.cpp index 0da6ae8..f4571ed 100644 --- a/ginac/pseries.cpp +++ b/ginac/pseries.cpp @@ -1280,11 +1280,7 @@ ex ex::series(const ex & r, int order, unsigned options) const else throw (std::logic_error("ex::series(): expansion point has unknown type")); - try { - e = bp->series(rel_, order, options); - } catch (std::exception &x) { - throw (std::logic_error(std::string("unable to compute series (") + x.what() + ")")); - } + e = bp->series(rel_, order, options); return e; } -- 1.5.3.2 -- All science is either physics or stamp collecting.

1 0

[PATCH] Fix memory leaks in mul::eval() and power::eval() (GiNaC 1.3)
by Alexei Sheplyakov 17 Nov '07

17 Nov '07

The bug was introduced by the patch commit f418c6ee4d558c852e1fb95533af07a3ae43f409 Author: Alexei Sheplyakov <varg(a)theor.jinr.ru> Date: Wed Jul 11 14:34:42 2007 +0400 (it was commited into the official branch as commit a602d34c225dceb3e53742a7b3e19a4b5e280485 Author: Jens Vollinga <vollinga(a)thep.physik.uni-mainz.de> Date: Wed Jul 11 21:07:40 2007 +0000) While at it, delete bogus try -- catch block in the ex::series(), since it papers over some serious issues (like this one) and does not seem to do anything useful. Thanks to valgrind (http://valgrind.kde.org) developers for a wonderful piece of software. Debugging this problem would take way too long without it. --- check/mul_eval_memleak.cpp | 119 ++++++++++++++++++++++++++++++++++++++++++++ ginac/mul.cpp | 4 +- ginac/power.cpp | 4 +- ginac/pseries.cpp | 6 +-- 4 files changed, 124 insertions(+), 9 deletions(-) create mode 100644 check/mul_eval_memleak.cpp diff --git a/check/mul_eval_memleak.cpp b/check/mul_eval_memleak.cpp new file mode 100644 index 0000000..78e9312 --- /dev/null +++ b/check/mul_eval_memleak.cpp @@ -0,0 +1,119 @@ +/** + * @file mul_eval_memleak.cpp Test for memory leak in {mul,power}::eval + * + * The bug was introduced by + * + * commit f418c6ee4d558c852e1fb95533af07a3ae43f409 + * Author: Alexei Sheplyakov <varg(a)theor.jinr.ru> + * Date: Wed Jul 11 14:34:42 2007 +0400 + * (it was commited into the official branch as + * commit a602d34c225dceb3e53742a7b3e19a4b5e280485 + * Author: Jens Vollinga <vollinga(a)thep.physik.uni-mainz.de> + * Date: Wed Jul 11 21:07:40 2007 +0000) + */ + +/* + * GiNaC Copyright (C) 1999-2007 Johannes Gutenberg University Mainz, Germany + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include <iostream> +#include <ginac/ginac.h> +#include <string> +#include <stdexcept> +using namespace std; +using namespace GiNaC; + +const unsigned check_mul_eval_memleak(const unsigned N) +{ + // Expanding this expression into a Laurent series triggers the bug. + static const string e_str("\ +1/605927415293858601*tgamma(3-eps)^(-1)*tgamma(2-eps)*(5013234896802\ +*(-1+2*eps)*((-2539001/2)*eps^(-2)+(-7617003/2+1692800*log(920*scale\ +^(-1))+3385202*log(1301*scale^(-1)))*eps^(-1)+F)+(846400+2539001*eps\ +)*(2539001*(-1+2*eps)*((-2539001/2)*eps^(-2)+(-7617003/2+1692800*log\ +(920*scale^(-1))+3385202*log(1301*scale^(-1)))*eps^(-1)+F)+286523497\ +2800*(-1+eps)^(-1)*eps^(-2)*(920*scale^(-1))^(-2*eps)*(1301*scale^(-\ +1))^(-2*eps)*tgamma(1+eps)^2)+6061411748045832000*(-1+eps)^(-1)*eps^\ +(-2)*(920*scale^(-1))^(-2*eps)*(1301*scale^(-1))^(-2*eps)*tgamma(1+e\ +ps)^2+716056132401*((-2539001/2)*eps^(-2)+(-7617003/2+1692800*log(92\ +0*scale^(-1))+3385202*log(1301*scale^(-1)))*eps^(-1)+F))+71656139360\ +0/716056132401*tgamma(1-eps)*tgamma(2*eps)^(-1)*tgamma(eps)^2*tgamma\ +(3-eps)^(-1)*(920*scale^(-1))^(-4*eps)*tgamma(-1+2*eps)-2/6059274152\ +93858601*tgamma(3-eps)^(-1)*(2149010446400*(-1+2*eps)*((-2539001/2)*\ +eps^(-2)+(-7617003/2+1692800*log(920*scale^(-1))+3385202*log(1301*sc\ +ale^(-1)))*eps^(-1)+F)+2425134880977920000*(-1+eps)^(-1)*eps^(-2)*(9\ +20*scale^(-1))^(-2*eps)*(1301*scale^(-1))^(-2*eps)*tgamma(1+eps)^2-7\ +16056132401*((-2539001/2)*eps^(-2)+(-7617003/2+1692800*log(920*scale\ +^(-1))+3385202*log(1301*scale^(-1)))*eps^(-1)+F)+1692601*(-1+2*eps)*\ +(2539001*(-1+2*eps)*((-2539001/2)*eps^(-2)+(-7617003/2+1692800*log(9\ +20*scale^(-1))+3385202*log(1301*scale^(-1)))*eps^(-1)+F)+28652349728\ +00*(-1+eps)^(-1)*eps^(-2)*(920*scale^(-1))^(-2*eps)*(1301*scale^(-1)\ +)^(-2*eps)*tgamma(1+eps)^2))*tgamma(2-eps)+(1/716056132401*I)*tgamma\ +(-1+eps)*mb^2*(mb*scale^(-1))^(-2*eps)*((716392960000*I)*mb^(-2)*(92\ +0*scale^(-1))^(-2*eps)*tgamma(-2+eps)-(2864898145201*I)*mb^(-2)*(130\ +1*scale^(-1))^(-2*eps)*tgamma(-2+eps)-(716224526400*I)*tgamma(-1+eps\ +)*mb^(-2)*(920*scale^(-1))^(-2*eps))-3385202/605927415293858601*tgam\ +ma(3-eps)^(-1)*tgamma(2-eps)*(2539001*(-1+2*eps)*((-2539001/2)*eps^(\ +-2)+(-7617003/2+1692800*log(920*scale^(-1))+3385202*log(1301*scale^(\ +-1)))*eps^(-1)+F)+2865234972800*(-1+eps)^(-1)*eps^(-2)*(920*scale^(-\ +1))^(-2*eps)*(1301*scale^(-1))^(-2*eps)*tgamma(1+eps)^2+846201*((-25\ +39001/2)*eps^(-2)+(-7617003/2+1692800*log(920*scale^(-1))+3385202*lo\ +g(1301*scale^(-1)))*eps^(-1)+F))\ +"); + const symbol eps("eps"), scale("scale"), mb("mb"), F("F"); + const lst syms(eps, scale, mb, F); + const ex e0(e_str, syms); + + unsigned i = 0; + unsigned n_failures = 0; + + ex e; + try { + for (; i < N; i++) + e = e0.series(eps, 1).subs(Euler==0).expand(); + } catch (std::bad_alloc) { + return i; + } + return 0; +} + +#include <sys/types.h> +#include <sys/time.h> +#include <sys/resource.h> +#include <unistd.h> + +static void set_VM_limit(const unsigned long MB) { + const unsigned mem_lim_kb = MB*1024*1024; + struct rlimit lim; + lim.rlim_cur = mem_lim_kb; + lim.rlim_max = mem_lim_kb; + setrlimit(RLIMIT_AS, &lim); +} + +int main(int argc, char** argv) { + static const unsigned max_mem = 32; // megabytes + // otherwise one need wait for a long[er] time. + set_VM_limit(max_mem); + static const unsigned n_of_tests = 10000; + const unsigned n_loops = check_mul_eval_memleak(n_of_tests); + if (n_loops) { + cerr << "memory exhausted after " << n_loops << " loops" << endl; + return 1; + } + return 0; +} + diff --git a/ginac/mul.cpp b/ginac/mul.cpp index 99d811f..ab1a042 100644 --- a/ginac/mul.cpp +++ b/ginac/mul.cpp @@ -461,8 +461,8 @@ ex mul::eval(int level) const // XXX: What is the best way to check if the polynomial is a primitive? numeric c = i->rest.integer_content(); - const numeric& lead_coeff = - ex_to<numeric>(ex_to<add>(i->rest).seq.begin()->coeff).div_dyn(c); + const numeric lead_coeff = + ex_to<numeric>(ex_to<add>(i->rest).seq.begin()->coeff).div(c); const bool canonicalizable = lead_coeff.is_integer(); // XXX: The main variable is chosen in a random way, so this code diff --git a/ginac/power.cpp b/ginac/power.cpp index e839220..099f935 100644 --- a/ginac/power.cpp +++ b/ginac/power.cpp @@ -491,8 +491,8 @@ ex power::eval(int level) const // (2*x + 6*y)^(-4) -> 1/16*(x + 3*y)^(-4) if (num_exponent->is_integer() && is_exactly_a<add>(ebasis)) { numeric icont = ebasis.integer_content(); - const numeric& lead_coeff = - ex_to<numeric>(ex_to<add>(ebasis).seq.begin()->coeff).div_dyn(icont); + const numeric lead_coeff = + ex_to<numeric>(ex_to<add>(ebasis).seq.begin()->coeff).div(icont); const bool canonicalizable = lead_coeff.is_integer(); const bool unit_normal = lead_coeff.is_pos_integer(); diff --git a/ginac/pseries.cpp b/ginac/pseries.cpp index 2b948a7..6ff1d96 100644 --- a/ginac/pseries.cpp +++ b/ginac/pseries.cpp @@ -1215,11 +1215,7 @@ ex ex::series(const ex & r, int order, unsigned options) const else throw (std::logic_error("ex::series(): expansion point has unknown type")); - try { - e = bp->series(rel_, order, options); - } catch (std::exception &x) { - throw (std::logic_error(std::string("unable to compute series (") + x.what() + ")")); - } + e = bp->series(rel_, order, options); return e; } -- 1.5.3.2 -- All science is either physics or stamp collecting.

1 0

[PATCH] fix broken perprocessor instruction, so GiNaC compiles when ! HAVE_LIBDL.
by Alexei Sheplyakov 06 Nov '07

06 Nov '07

Hi! I've tried to build GiNaC 1.4 on my ReactOS box, it failed due to broken preprocessor instruction in excomplier.cpp. The patch below fixes it. --- ginac/excompiler.cpp | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/ginac/excompiler.cpp b/ginac/excompiler.cpp index fe96123..4cf2841 100644 --- a/ginac/excompiler.cpp +++ b/ginac/excompiler.cpp @@ -32,7 +32,9 @@ #include <string> #include <vector> +#ifdef HAVE_CONFIG_H #include "config.h" +#endif #ifdef HAVE_LIBDL #include <dlfcn.h> @@ -302,7 +304,7 @@ void unlink_ex(const std::string filename) global_excompiler.unlink(filename); } -#elif // def HAVE_LIBDL +#else // def HAVE_LIBDL /* * In case no working libdl has been found by configure, the following function -- 1.5.3.2 -- All science is either physics or stamp collecting.

1 0

Re: [GiNaC-cvs] ginac flags.h mul.cpp power.cpp
by Richard B. Kreckel 05 Nov '07

05 Nov '07

CVS Service wrote: > Update of /home/cvs/GiNaC/ginac by vollinga > > Modified Files: > Tag: ginac_1-4 > flags.h mul.cpp power.cpp > Log Message: > Synced to HEAD: > - This helps mul::expand() and friends to recognize objects which have > no indices at all [Sheplyakov]. Chris, We are curious what can be done about the performance regression one of your patches for dummy index renaming introduced. The seemingly innocuous patch has been identified by Jens and Alexei: <http://www.ginac.de/pipermail/ginac-list/2007-September/001215.html>. At first, the above log message suggested to me that the problem has been dealt with. But that is not so: The program is still extremely slow. In fact, Alexei's patches are entirely unrelated. Since neither an explanation of what's happening nor a fix has been suggested, we would really appreciate some expert insight by you. Thanks in advance -richy. -- Richard B. Kreckel <http://www.ginac.de/~kreckel/>

4 5

Restore the speed of polynomial operations.
by Alexei Sheplyakov 18 Sep '07

18 Sep '07

Hello! These patches commit 0633ed8082961673eedc092689e06fa39d6bc322 Author: Jens Vollinga <vollinga(a)thep.physik.uni-mainz.de> Date: Thu May 19 18:10:40 2005 +0000 Fixed bug in expanding expressions containing dummy indices. [V.Kisil] (see <http://www.ginac.de/pipermail/ginac-cvs/2005-May/001586.html>) commit 6b1b11264fe4872132fef8cb8b22cb983ba01736 Author: Chris Dams <Chris.Dams(a)mi.infn.it> Date: Thu Jul 13 20:02:38 2006 +0000 Needed to call get_all_dummy_indices_safely more often. (see http://www.ginac.de/pipermail/ginac-cvs/2006-July/001780.html) commit 4cf53676d7823ec3c55a90df7723f7f1492a95b2 Author: Chris Dams <Chris.Dams(a)mi.infn.it> Date: Mon Jul 24 16:47:43 2006 +0000 Improved dummy index renaming. (see http://www.ginac.de/pipermail/ginac-cvs/2006-July/001782.html) made polynomial operations (in particular expand()) substantially slower. For example, Fateman's polynomial expanding benchark degraded from 32sec. to 80sec. My own code which uses multivariate GCD (which in turn uses .expand() extensively) become 4x slower. I'll post 4 patches which address the issue in reply to this message. Comments, questions, suggestions, etc. are wellcome. Best regards, Alexei -- All science is either physics or stamp collecting.

3 12