- GiNaC-devel - ginac.de

[SCM] GiNaC -- a C++ library for symbolic computations branch, ginac_1-5, updated. release_1-4-0-257-gc5be6a0
by git＠ginac.de 09 Dec '10

09 Dec '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GiNaC -- a C++ library for symbolic computations". The branch, ginac_1-5 has been updated via c5be6a0d868b7fbf2bf51ed3ee2d2f50d3574b99 (commit) from 59fa68b8930779dfc419291d028b57b0d91d33d0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c5be6a0d868b7fbf2bf51ed3ee2d2f50d3574b99 Author: Richard Kreckel <kreckel(a)ginac.de> Date: Thu Dec 9 09:18:34 2010 +0100 Make symbol::name be initialized lazily. This fixes symbol::get_name(), which returned an empty string instead of "symbol" followed by the serial number if the symbol's name wasn't specified in the constructor. Thanks to Warren Weckesser for reporting this bug. (cherry picked from commit f5abf61d2cb1a1d1809d270a24fa098575b172c4) ----------------------------------------------------------------------- Summary of changes: ginac/symbol.cpp | 17 +++++++++++++---- ginac/symbol.h | 6 +++--- 2 files changed, 16 insertions(+), 7 deletions(-) hooks/post-receive -- GiNaC -- a C++ library for symbolic computations

1 0

[SCM] GiNaC -- a C++ library for symbolic computations branch, ginac_1-5, updated. release_1-4-0-256-g59fa68b
by git＠ginac.de 04 Dec '10

04 Dec '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GiNaC -- a C++ library for symbolic computations". The branch, ginac_1-5 has been updated via 59fa68b8930779dfc419291d028b57b0d91d33d0 (commit) via eccdca0011fc44bc14cfcb7ffd82dbcb653e19a5 (commit) from d41f7533018d9f9444c98466432e4d84deedaa04 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 59fa68b8930779dfc419291d028b57b0d91d33d0 Author: Alexei Sheplyakov <alexei.sheplyakov(a)gmail.com> Date: Sat Dec 4 00:36:50 2010 +0100 [PATCH 2/2] chinrem_gcd: return correct integer content when GCD is a number. This patch fixes a silly typo and makes chinrem_gcd work correctly with polynomials which are "almost" (up to an integer coefficient) relatively prime. Thanks to Ernst Moritz Hahn for a bug report and a test case. (cherry picked from commit 00507499530d90533cf029bd503be326d9018138) commit eccdca0011fc44bc14cfcb7ffd82dbcb653e19a5 Author: Alexei Sheplyakov <alexei.sheplyakov(a)gmail.com> Date: Sat Dec 4 00:35:06 2010 +0100 [PATCH 1/2] extract_integer_content: check for rational numbers properly. Commit 3d09388a (titled as `[bugfix] chinrem_gcd: handle polynomials over rationals properly.') broke extract_integer_content: now it always returns 1. The check for rational `integer_contnent' introduced by that commit is wrong (since integers is a subset of rationals). Rewrite the check proprerly. (cherry picked from commit f0fb303711b4334ce59f7da63bfa7cb49f46265f) ----------------------------------------------------------------------- Summary of changes: check/bugme_chinrem_gcd.cpp | 13 +++++++++++++ ginac/polynomial/mgcd.cpp | 22 ++++++++++++---------- 2 files changed, 25 insertions(+), 10 deletions(-) hooks/post-receive -- GiNaC -- a C++ library for symbolic computations

1 0

[SCM] GiNaC -- a C++ library for symbolic computations branch, master, updated. release_1-4-0-237-g0050749
by git＠ginac.de 04 Dec '10

04 Dec '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GiNaC -- a C++ library for symbolic computations". The branch, master has been updated via 00507499530d90533cf029bd503be326d9018138 (commit) via f0fb303711b4334ce59f7da63bfa7cb49f46265f (commit) from 3d09388a8ea144a19949c216fae43ccba92e47aa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 00507499530d90533cf029bd503be326d9018138 Author: Alexei Sheplyakov <alexei.sheplyakov(a)gmail.com> Date: Sat Dec 4 00:36:50 2010 +0100 [PATCH 2/2] chinrem_gcd: return correct integer content when GCD is a number. This patch fixes a silly typo and makes chinrem_gcd work correctly with polynomials which are "almost" (up to an integer coefficient) relatively prime. Thanks to Ernst Moritz Hahn for a bug report and a test case. commit f0fb303711b4334ce59f7da63bfa7cb49f46265f Author: Alexei Sheplyakov <alexei.sheplyakov(a)gmail.com> Date: Sat Dec 4 00:35:06 2010 +0100 [PATCH 1/2] extract_integer_content: check for rational numbers properly. Commit 3d09388a (titled as `[bugfix] chinrem_gcd: handle polynomials over rationals properly.') broke extract_integer_content: now it always returns 1. The check for rational `integer_contnent' introduced by that commit is wrong (since integers is a subset of rationals). Rewrite the check proprerly. ----------------------------------------------------------------------- Summary of changes: check/bugme_chinrem_gcd.cpp | 13 +++++++++++++ ginac/polynomial/mgcd.cpp | 22 ++++++++++++---------- 2 files changed, 25 insertions(+), 10 deletions(-) hooks/post-receive -- GiNaC -- a C++ library for symbolic computations

1 0

[PATCH 2/2] chinrem_gcd: return correct integer content when GCD is a number.
by Alexei Sheplyakov 03 Dec '10

03 Dec '10

This patch fixes a silly typo and makes chinrem_gcd work correctly with polynomials which are "almost" (up to an integer coefficient) relatively prime. Thanks to Ernst Moritz Hahn for a bug report and a test case. --- check/bugme_chinrem_gcd.cpp | 13 +++++++++++++ ginac/polynomial/mgcd.cpp | 2 +- 2 files changed, 14 insertions(+), 1 deletions(-) diff --git a/check/bugme_chinrem_gcd.cpp b/check/bugme_chinrem_gcd.cpp index 87c718c..eaca381 100644 --- a/check/bugme_chinrem_gcd.cpp +++ b/check/bugme_chinrem_gcd.cpp @@ -54,11 +54,24 @@ static void check_extract_integer_content() ex g = chinrem_gcd(A, B); } +static void integer_coeff_braindamage() +{ + parser readme; + ex A = readme("3*x^2 + 1"); + ex B = readme("9*x^2 + 1"); + ex g = chinrem_gcd(A, B); + if (!g.is_equal(ex(1))) { + std::cerr << "expected 1, got " << g << std::endl; + throw std::logic_error("chinrem_gcd miscomputed integer content"); + } +} + int main(int argc, char** argv) { cout << "checking for bugs in poly_cra() and friends " << flush; check_poly_cra(); check_extract_integer_content(); + integer_coeff_braindamage(); cout << "not found."; return 0; } diff --git a/ginac/polynomial/mgcd.cpp b/ginac/polynomial/mgcd.cpp index 7500805..901f075 100644 --- a/ginac/polynomial/mgcd.cpp +++ b/ginac/polynomial/mgcd.cpp @@ -101,7 +101,7 @@ ex chinrem_gcd(const ex& A_, const ex& B_, const exvector& vars) Cp = (Cp*numeric(nlc)).expand().smod(pnum); exp_vector_t cp_deg = degree_vector(Cp, vars); if (zerop(cp_deg)) - return numeric(g_lc); + return numeric(c); if (zerop(q)) { H = Cp; n = cp_deg; -- 1.7.2.3

1 0

[PATCH 1/2] extract_integer_content: check for rational numbers properly.
by Alexei Sheplyakov 03 Dec '10

03 Dec '10

Commit 3d09388a (titled as `[bugfix] chinrem_gcd: handle polynomials over rationals properly.') broke extract_integer_content: now it always returns 1. The check for rational `integer_contnent' introduced by that commit is wrong (since integers is a subset of rationals). Rewrite the check proprerly. --- ginac/polynomial/mgcd.cpp | 20 +++++++++++--------- 1 files changed, 11 insertions(+), 9 deletions(-) diff --git a/ginac/polynomial/mgcd.cpp b/ginac/polynomial/mgcd.cpp index 5b9da12..7500805 100644 --- a/ginac/polynomial/mgcd.cpp +++ b/ginac/polynomial/mgcd.cpp @@ -40,21 +40,23 @@ static cln::cl_I extract_integer_content(ex& Apr, const ex& A) { static const cln::cl_I n1(1); const numeric icont_ = A.integer_content(); + if (cln::instanceof(icont_.to_cl_N(), cln::cl_I_ring)) { + const cln::cl_I icont = cln::the<cln::cl_I>(icont_.to_cl_N()); + if (icont != 1) { + Apr = (A/icont_).expand(); + return icont; + } else { + Apr = A; + return n1; + } + } if (cln::instanceof(icont_.to_cl_N(), cln::cl_RA_ring)) { Apr = (A/icont_).expand(); // A is a polynomail over rationals, so GCD is defined // up to arbitrary rational number. return n1; } - GINAC_ASSERT(cln::instanceof(icont_.to_cl_N(), cln::cl_I_ring)); - const cln::cl_I icont = cln::the<cln::cl_I>(icont_.to_cl_N()); - if (icont != 1) { - Apr = (A/icont_).expand(); - return icont; - } else { - Apr = A; - return n1; - } + GINAC_ASSERT(NULL == "expected polynomial over integers or rationals"); } ex chinrem_gcd(const ex& A_, const ex& B_, const exvector& vars) -- 1.7.2.3

1 0

[SCM] GiNaC -- a C++ library for symbolic computations branch, ginac_1-5, updated. release_1-4-0-254-gd41f753
by git＠ginac.de 23 Nov '10

23 Nov '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GiNaC -- a C++ library for symbolic computations". The branch, ginac_1-5 has been updated via d41f7533018d9f9444c98466432e4d84deedaa04 (commit) from 1d73fed17debbc88819dc7f84a4a2e608d8eb978 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d41f7533018d9f9444c98466432e4d84deedaa04 Author: Alexei Sheplyakov <alexei.sheplyakov(a)gmail.com> Date: Tue Nov 23 17:45:52 2010 +0100 [bugfix] chinrem_gcd: handle polynomials over rationals properly. * extract_integer_content(): integer_content() can also return a rational number, e.g if the expression is a polynomial over rationals (in this case expr/content is polynomial over integers with integer content being 1). Therefore check if integer_content() is really an integer (and if it's not just return 1, GCD for polynomials over a field is defined up to arbitrary element of the field). This fixes possible segfault when computing GCD of polynomials over rationals (this is not theoretical, see the added test case). Thanks to Ernst Moritz Hahn for reporting this bug. (cherry picked from commit 3d09388a8ea144a19949c216fae43ccba92e47aa) ----------------------------------------------------------------------- Summary of changes: check/bugme_chinrem_gcd.cpp | 18 ++++++++++++++++-- ginac/polynomial/mgcd.cpp | 10 ++++++++++ 2 files changed, 26 insertions(+), 2 deletions(-) hooks/post-receive -- GiNaC -- a C++ library for symbolic computations

1 0

[SCM] GiNaC -- a C++ library for symbolic computations branch, master, updated. release_1-4-0-235-g3d09388
by git＠ginac.de 23 Nov '10

23 Nov '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GiNaC -- a C++ library for symbolic computations". The branch, master has been updated via 3d09388a8ea144a19949c216fae43ccba92e47aa (commit) from 079c558d4f9758cd2777a2808a02d64cb1f70c8e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3d09388a8ea144a19949c216fae43ccba92e47aa Author: Alexei Sheplyakov <alexei.sheplyakov(a)gmail.com> Date: Tue Nov 23 17:45:52 2010 +0100 [bugfix] chinrem_gcd: handle polynomials over rationals properly. * extract_integer_content(): integer_content() can also return a rational number, e.g if the expression is a polynomial over rationals (in this case expr/content is polynomial over integers with integer content being 1). Therefore check if integer_content() is really an integer (and if it's not just return 1, GCD for polynomials over a field is defined up to arbitrary element of the field). This fixes possible segfault when computing GCD of polynomials over rationals (this is not theoretical, see the added test case). Thanks to Ernst Moritz Hahn for reporting this bug. ----------------------------------------------------------------------- Summary of changes: check/bugme_chinrem_gcd.cpp | 18 ++++++++++++++++-- ginac/polynomial/mgcd.cpp | 10 ++++++++++ 2 files changed, 26 insertions(+), 2 deletions(-) hooks/post-receive -- GiNaC -- a C++ library for symbolic computations

1 0

[PATCH] [bugfix] chinrem_gcd: handle polynomials over rationals properly.
by Alexei Sheplyakov 23 Nov '10

23 Nov '10

* extract_integer_content(): integer_content() can also return a rational number, e.g if the expression is a polynomial over rationals (in this case expr/content is polynomial over integers with integer content being 1). Therefore check if integer_content() is really an integer (and if it's not just return 1, GCD for polynomials over a field is defined up to arbitrary element of the field). This fixes possible segfault when computing GCD of polynomials over rationals (this is not theoretical, see the added test case). --- check/bugme_chinrem_gcd.cpp | 18 ++++++++++++++++-- ginac/polynomial/mgcd.cpp | 10 ++++++++++ 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/check/bugme_chinrem_gcd.cpp b/check/bugme_chinrem_gcd.cpp index d3c0330..87c718c 100644 --- a/check/bugme_chinrem_gcd.cpp +++ b/check/bugme_chinrem_gcd.cpp @@ -38,13 +38,27 @@ static const std::string p1_srep("\ static const std::string p2_srep("\ 1882371920+29943249139*x^9-21558061051*x^35+24497174109*x^69+3363043648*x^25+5186524611*x^98-17753230977*x^56+16461882236*x^72+11039962159*x^11-85814533599*x^43-12986831645*x^85+4813620791*x^29-2133682609*x^2+9141433582*x^88-14841292646*x^13+19494168654*x^51-426278523*x^15-18246235652*x^59-12424469513*x^16-14414308862*x^38-16262001424*x^75+1584505491*x^3+6616907060*x^46+9411879011*x^91+7056872613*x^20+29675566382*x^78-48441925739*x^54+12038293769*x^33-22463329638*x^65+21957440404*x^41+26252749471*x^81-28689993421*x^24+1190623161*x^94-3323333429*x^62+778770195*x^68-23673866858*x^49+10263027507*x^97+29115114125*x^28-34230002076*x^36-217623403*x^71-6344703601*x^84+2789684836*x^100-44973929094*x^57-6061422988*x^44+18964048763*x^87+3160532878*x^8-8039690791*x^19-5750277357*x^74+5544486596*x^23+1800283356*x^90-8174921854*x^52+2577247520*x^64-1088265300*x^10+18566882873*x^39+12678193001*x^77-7204610489*x^27+9980611956*x^60+12672890141*x^80+4463462090*x^12-30937311949*x^47-3883570155*x^93+7561875663*x^14-3850452489*x^55+20714527103*x^31-9973372012*x^34+440594870*x^67+10385086102*x^96-20693764726*x^63+11049483001*x^18-11578701274*x^70-5548876327*x^42+20393397488*x^83+20531692560*x^50+1309311388*x^99-7521320830*x-2750892631*x^37-6001481047*x^73+7149046134*x^22+10287410396*x^86+7332053562*x^58-1135211878*x^4-7420079075*x^45+9742202475*x^89-214559874*x^26+29530802947*x^30-2280622009*x^32-4237029618*x^5+13760397067*x^76+18073788685*x^53+2485463829*x^40+1889202286*x^79+8841198971*x^6+13562767020*x^92+110919258*x^7+6961020716*x^61+11700952246*x^17-13528331424*x^66-19801882818*x^21+25061328813*x^82+1553111326*x^48+4638169279*x^95"); -int main(int argc, char** argv) +static void check_poly_cra() { - cout << "checking for bugs in poly_cra() " << flush; parser the_parser; ex p1 = the_parser(p1_srep); ex p2 = the_parser(p2_srep); ex g = chinrem_gcd(p1, p2); +} + +static void check_extract_integer_content() +{ + parser readme; + ex A = readme("1/282901891126422365*(x + y)"); + ex B = readme("165888/282901891126422365*(x - y)"); + ex g = chinrem_gcd(A, B); +} + +int main(int argc, char** argv) +{ + cout << "checking for bugs in poly_cra() and friends " << flush; + check_poly_cra(); + check_extract_integer_content(); cout << "not found."; return 0; } diff --git a/ginac/polynomial/mgcd.cpp b/ginac/polynomial/mgcd.cpp index 24da934..5b9da12 100644 --- a/ginac/polynomial/mgcd.cpp +++ b/ginac/polynomial/mgcd.cpp @@ -30,6 +30,9 @@ #include <numeric> // std::accumulate #include <cln/integer.h> +#include <cln/integer_ring.h> +#include <cln/rational.h> +#include <cln/rational_ring.h> namespace GiNaC { @@ -37,6 +40,13 @@ static cln::cl_I extract_integer_content(ex& Apr, const ex& A) { static const cln::cl_I n1(1); const numeric icont_ = A.integer_content(); + if (cln::instanceof(icont_.to_cl_N(), cln::cl_RA_ring)) { + Apr = (A/icont_).expand(); + // A is a polynomail over rationals, so GCD is defined + // up to arbitrary rational number. + return n1; + } + GINAC_ASSERT(cln::instanceof(icont_.to_cl_N(), cln::cl_I_ring)); const cln::cl_I icont = cln::the<cln::cl_I>(icont_.to_cl_N()); if (icont != 1) { Apr = (A/icont_).expand(); -- 1.7.2.3

1 0

CLN linker issue
by Aless Lasaruk 09 Nov '10

09 Nov '10

Dear GiNaC developers, i have noticed that the default build of GiNaC from the release tars does not seem to link against the CLN-library. My configuration: Mac OSX Leopard GiNaC 1.5.8 release (from scratch: untar, configure, make, make install). GNU from mac ports. This results in strange linker behaviour, when working with the "numeric" class: Undefined symbols: "cln::cl_free_heap_object(cln::cl_heap*)", referenced from: cln::cl_gc_dec_pointer_refcount(cln::cl_heap*) in numeric.cpp.o ld: symbol(s) not found collect2: ld returned 1 exit status I suppose, this linker error is heavy to understand for beginners, so i suggest to fix or document this issue. With best regards, Aless -- Aless Lasaruk Scientific Assistant, FORWISS Room 204, ITZ, Innstrasse 43 Universität Passau D-94030 Passau (Germany) Mail: lasaruk(a)uni-passau.de Tel.: +49(0)851/509-3173 Fax : +49(0)851/509-3142

2 1

[SCM] GiNaC -- a C++ library for symbolic computations branch, ginac_1-5, updated. release_1-4-0-253-g1d73fed
by git＠ginac.de 09 Nov '10

09 Nov '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GiNaC -- a C++ library for symbolic computations". The branch, ginac_1-5 has been updated via 1d73fed17debbc88819dc7f84a4a2e608d8eb978 (commit) from 052f124551d2b78104b0de2008db6b8819713625 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1d73fed17debbc88819dc7f84a4a2e608d8eb978 Author: Alexei Sheplyakov <alexei.sheplyakov(a)gmail.com> Date: Tue Nov 9 08:27:47 2010 +0100 power::series(): handle someg (trivial) singularities of the exponent... ... so GiNaC can expand expressions like cos(x)^(sin(x)/x) // (x -> 0) (1 + x)^(1/x) // x -> 0 and so on. [Reported by Camille Gillot.] (cherry picked from commit 079c558d4f9758cd2777a2808a02d64cb1f70c8e) ----------------------------------------------------------------------- Summary of changes: check/exam_pseries.cpp | 18 ++++++++++++++++++ ginac/pseries.cpp | 23 +++++++++++++++++++++++ 2 files changed, 41 insertions(+), 0 deletions(-) hooks/post-receive -- GiNaC -- a C++ library for symbolic computations

1 0