Re: [GiNaC-list] [patch] Add solve_algo::markowitz for large sparse systems
8 Jun
2018
8 Jun
'18
11 a.m.
On 05/31/2018 05:55 PM, Richard B. Kreckel wrote:
Thanks a lot for your contribution! After doing some (probably too simplistic) checks with your implementation of Markowitz-ordered Gaussian elimination and finding no issues I've committed it.
Regarding style, I've taken the liberty to adjust indentation a little bit to comply with <https://www.cebix.net/indentation.html>.
Thanks; I tried to mimic the style of the rest of the code, but it turned out to be challenging. Is there a set of vim options that implement this style?
Also, please let's keep the continue statements in conditionals on a line of their own. This improves debuggability. Apart from that, it's perfect.
Sure.
2578
Age (days ago)
2578
Last active (days ago)
0 comments
1 participants
participants (1)
-
Vitaly Magerya