Hi Chris, On Tue, Jun 28, 2005 at 04:31:25PM +0200, Chris Dams wrote:
I also thought that this should go into 1.4.0 because it changes the interface. I.e., it removes the references to flyweights. E.g. it removes _num_120. However, no *.h file uses the refs to flyweights. Users could be using the flyweights in their code and then it would break. However, the comments in utils.h say that users should not do this. So, having looked at it again, I think that it is safe to put it in 1.3.2. I tested this by compiling a program under 1.3.1 and after that running it again with the patched version of the library installed. This works correctly.
why did the references have to go? I don't understand this, yet. In the Jan 20th mail you say it crashes otherwise. Do you have an explanation? It is not so important for me, if not. It just would be nice to understand that behavior. Did it also crash with references when the line const ex _ex30 = _num30; had been changed to const ex _ex30 = _ex30; (i.e. your Jan 8th patch with that additional change) ?? Regards, Jens