[SCM] GiNaC -- a C++ library for symbolic computations branch, master, updated. release_1-4-0-350-g2205b83
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GiNaC -- a C++ library for symbolic computations". The branch, master has been updated via 2205b83add319eb883b416c96a14b5866667baaa (commit) from 89d1222669c6fbfcf91b50120a042dbe7d73e35f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2205b83add319eb883b416c96a14b5866667baaa Author: Jens Vollinga <jensv@nikhef.nl> Date: Sun May 22 16:19:17 2011 +0200 This patch fixes a bug on machines where char is unsigned by default, by extending the type of clifford_max_label to include all 257 possible return values. Thanks to Martin Guy for the bug report and patch. ----------------------------------------------------------------------- Summary of changes: ginac/add.cpp | 2 +- ginac/clifford.cpp | 4 ++-- ginac/clifford.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- GiNaC -- a C++ library for symbolic computations
Hi,
- Log ----------------------------------------------------------------- commit 2205b83add319eb883b416c96a14b5866667baaa Author: Jens Vollinga <jensv@nikhef.nl> Date: Sun May 22 16:19:17 2011 +0200
This patch fixes a bug on machines where char is unsigned by default, by extending the type of clifford_max_label to include all 257 possible return values. Thanks to Martin Guy for the bug report and patch.
-----------------------------------------------------------------------
Summary of changes: ginac/add.cpp | 2 +- ginac/clifford.cpp | 4 ++-- ginac/clifford.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
That patch is bogus. See http://www.ginac.de/pipermail/ginac-devel/2011-April/001870.html for more details. However, it's also harmless (and we broke the ABI anyway). Perhaps it's even a bit useful, as it will prevent similar nonsense patches from popping up. Best regards, Alexei
Hi, Am 22.05.2011 16:41, schrieb Alexei Sheplyakov:
That patch is bogus. See http://www.ginac.de/pipermail/ginac-devel/2011-April/001870.html for more details. However, it's also harmless (and we broke the ABI anyway). Perhaps it's even
Bogus is a bit strong. We explicitly mention in the manual that one can use values from 0 to 255 as labels. If a user is obstinate enough to use 255, he might run into bug on certain machines. Yes, this is a lot of ifs and whens and I agree with you that this patch is unnecessary in most cases, but nevertheless it does prevent a potential problem.
a bit useful, as it will prevent similar nonsense patches from popping up.
:-) Regards, Jens
participants (3)
-
Alexei Sheplyakov
-
git@ginac.de
-
Jens Vollinga