[SCM] GiNaC -- a C++ library for symbolic computations branch, master, updated. release_1-4-0-149-g40d2f5d
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GiNaC -- a C++ library for symbolic computations". The branch, master has been updated via 40d2f5d1ddacf71991adb447b163a19136ee2179 (commit) via 931ece4838fcef7b9ec71761d224e2e1cd11a89d (commit) via e989719ca767691eb75b34785baaaed716ea2624 (commit) from 4fb48e28063e08c613a773378cfa5de608560a84 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 40d2f5d1ddacf71991adb447b163a19136ee2179 Author: Jens Vollinga <jensv@balin.nikhef.nl> Date: Wed Nov 5 11:31:35 2008 +0100 Fixed some minor spelling errors. commit 931ece4838fcef7b9ec71761d224e2e1cd11a89d Author: Jens Vollinga <jensv@balin.nikhef.nl> Date: Wed Nov 5 11:22:19 2008 +0100 Changed code from using cl_UP_MI to using umodpoly. The cl_UP_MI interface was inconvenient to use and caused several very difficult bugs (some were still unresolved before changing to umodpoly!). Fixed severe bug in multivariate factorization. The condition that all modular factors should be relatively prime in the base ring was violated. This caused the factorization sometimes to go into an infinite loop. commit e989719ca767691eb75b34785baaaed716ea2624 Author: Jens Vollinga <jensv@balin.nikhef.nl> Date: Mon Nov 3 15:50:31 2008 +0100 Added code for distinct degree factorization. ----------------------------------------------------------------------- Summary of changes: doc/tutorial/ginac.texi | 6 +- ginac/factor.cpp | 1236 ++++++++++++++++++++++++++--------------------- 2 files changed, 682 insertions(+), 560 deletions(-) hooks/post-receive -- GiNaC -- a C++ library for symbolic computations
Hello, On Wed, Nov 05, 2008 at 12:52:28PM +0100, Jens Vollinga wrote:
commit e989719ca767691eb75b34785baaaed716ea2624 Author: Jens Vollinga <jensv@balin.nikhef.nl> Date: Mon Nov 3 15:50:31 2008 +0100
Added code for distinct degree factorization.
Thanks to stupid^W standard floating-integral conversions it fails to compile: make[2]: Entering directory `/home/pc7135/varg/tmp/build/ginac/ginac' /bin/sh ../libtool --tag=CXX --mode=compile ccache g++-4.1 -DHAVE_CONFIG_H -I. -I../config -I../../../../work/sw/ginac-official/ginac -I/usr/local/include -Wall -O2 -g -pipe -funroll-loops -ffast-math -finline-limit=1200 -m64 -march=k8 -mfpmath=sse -msse2 -MT factor.lo -MD -MP -MF .deps/factor.Tpo -c -o factor.lo ../../../../work/sw/ginac-official/ginac/factor.cpp libtool: compile: ccache g++-4.1 -DHAVE_CONFIG_H -I. -I../config -I../../../../work/sw/ginac-official/ginac -I/usr/local/include -Wall -O2 -g -pipe -funroll-loops -ffast-math -finline-limit=1200 -m64 -march=k8 -mfpmath=sse -msse2 -MT factor.lo -MD -MP -MF .deps/factor.Tpo -c ../../../../work/sw/ginac-official/ginac/factor.cpp -fPIC -DPIC -o .libs/factor.o ../../../../work/sw/ginac-official/ginac/factor.cpp: In function ‘void GiNaC::<unnamed>::distinct_degree_factor_BSGS(const GiNaC::<unnamed>::umodpoly&, GiNaC::<unnamed>::upvec&)’: ../../../../work/sw/ginac-official/ginac/factor.cpp:901: warning: converting to ‘int’ from ‘double’ ../../../../work/sw/ginac-official/ginac/factor.cpp:903: error: call of overloaded ‘pow(int&, int&)’ is ambiguous /usr/include/bits/mathcalls.h:154: note: candidates are: double pow(double, double) /usr/lib/gcc/x86_64-linux-gnu/4.1.2/../../../../include/c++/4.1.2/cmath:345: note: float std::pow(float, float) /usr/lib/gcc/x86_64-linux-gnu/4.1.2/../../../../include/c++/4.1.2/cmath:349: note: long double std::pow(long double, long double) /usr/lib/gcc/x86_64-linux-gnu/4.1.2/../../../../include/c++/4.1.2/cmath:353: note: double std::pow(double, int) /usr/lib/gcc/x86_64-linux-gnu/4.1.2/../../../../include/c++/4.1.2/cmath:357: note: float std::pow(float, int) /usr/lib/gcc/x86_64-linux-gnu/4.1.2/../../../../include/c++/4.1.2/cmath:361: note: long double std::pow(long double, int) Best regards, Alexei -- All science is either physics or stamp collecting.
commit e989719ca767691eb75b34785baaaed716ea2624 Author: Jens Vollinga <jensv@balin.nikhef.nl> Date: Mon Nov 3 15:50:31 2008 +0100
Added code for distinct degree factorization.
Thanks to stupid^W standard floating-integral conversions it fails to compile: [snipped]
I've "fixed" it in the following way: diff --git a/ginac/factor.cpp b/ginac/factor.cpp index 19549a2..8ca39c3 100644 --- a/ginac/factor.cpp +++ b/ginac/factor.cpp @@ -900,7 +900,8 @@ static void distinct_degree_factor_BSGS(const umodpoly& a, upvec& result) int m = std::ceil(((double)n)/2/l); upvec H(m); - int ql = std::pow(q, l); + // XXX: what happens if we have an overflow here? + int ql = cl_I_to_int(expt_pos(cl_I(q), l)); H[0] = h[l]; for ( int i=1; i<m; ++i ) { expt_pos(H[i-1], ql, qk); Best regards, Alexei -- All science is either physics or stamp collecting.
participants (2)
-
Alexei Sheplyakov
-
git＠ginac.de