[SCM] GiNaC -- a C++ library for symbolic computations branch, master, updated. release_1-4-0-661-g5f7f81ad
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GiNaC -- a C++ library for symbolic computations". The branch, master has been updated via 5f7f81ad35a80e12c6a9a2272e3882387732be4f (commit) from 933965916b34a17fa77c413dbc23699e26eaa9bf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5f7f81ad35a80e12c6a9a2272e3882387732be4f Author: Vladimir V. Kisil <V.Kisil@leeds.ac.uk> Date: Mon Jun 22 09:49:00 2020 +0200 [BUGFIX] Prevent crashes in find_common_factor() These happened if a non-normalised common factor was equal to zero. Thanks to Feng Feng for reporting this bug. ----------------------------------------------------------------------- Summary of changes: ginac/normal.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) hooks/post-receive -- GiNaC -- a C++ library for symbolic computations
Hello! 22.06.2020, 11:55, "Richard B. Kreckel via GiNaC-devel" <ginac-devel@ginac.de>:
- Log ----------------------------------------------------------------- commit 5f7f81ad35a80e12c6a9a2272e3882387732be4f Author: Vladimir V. Kisil <V.Kisil@leeds.ac.uk> Date: Mon Jun 22 09:49:00 2020 +0200
[BUGFIX] Prevent crashes in find_common_factor()
These happened if a non-normalised common factor was equal to zero.
Thanks to Feng Feng for reporting this bug.
The attached patch adds a test case.
On Tue, 23 Jun 2020 12:25:59 +0400, Alexey Sheplyakov <asheplyakov@yandex.ru> said:
ASh> The attached patch adds a test case. I have missed why we need the declaration of the parser p in the code... -- Vladimir V. Kisil http://www.maths.leeds.ac.uk/~kisilv/ Book: Geometry of Mobius Transformations http://goo.gl/EaG2Vu Software: Geometry of cycles http://moebinv.sourceforge.net/ Jupyter: https://github.com/vvkisil/MoebInv-notebooks
23.06.2020, 12:40, "Vladimir V. Kisil" <v.kisil@leeds.ac.uk>:
On Tue, 23 Jun 2020 12:25:59 +0400, Alexey Sheplyakov <asheplyakov@yandex.ru> said:
ASh> The attached patch adds a test case.
I have missed why we need the declaration of the parser p in the code...
Actually it's not necessary. And the comment is a bit misleading. I've fixed both problems in a new version (attached).
Hi, On 23.06.20 10:45, Alexey Sheplyakov wrote:
23.06.2020, 12:40, "Vladimir V. Kisil" <v.kisil@leeds.ac.uk>:
> On Tue, 23 Jun 2020 12:25:59 +0400, Alexey Sheplyakov <asheplyakov@yandex.ru> said:
ASh> The attached patch adds a test case.
I have missed why we need the declaration of the parser p in the code...
Actually it's not necessary. And the comment is a bit misleading. I've fixed both problems in a new version (attached).
So to avoid check/ becoming a mess, I propose renaming it to exam_collect_common_factor_zero.cpp in order to follow this nomenclature: exam: prefabricated tests (like pupils' exam) check: pore extensive randomized test vectors times: guess what! Also, the patch is missing mention in Makefile.am and CMakeList.txt. Oh, and: Thank you! -richy. -- Richard B. Kreckel <https://in.terlu.de/~kreckel/>
participants (4)
-
Alexey Sheplyakov
-
Richard B. Kreckel
-
Richard B. Kreckel
-
Vladimir V. Kisil