Dear Alexei, Alexei Sheplyakov wrote:
Remove silly checks from find_or_insert_symbol, and fix its return value (should be ex, not symbol).
Note: theoretically this change breaks the binary compatibility, since the return value of the function has been changed. However, the function in question is internal, and should be used only by GiNaC itself. Hence the patch is OK even for the stable (1.5) branch.
I've applied it. Let's put it like this: after all, it's a regression against the manual. :-/ Considering a recent thread on the GMP mailing list <http://gmplib.org/list-archives/gmp-discuss/2010-January/003983.html> I think that in the future we should strive to be more careful not to declare internal functions in header files that are going to be installed. Cheers -richy. PS: Jens, say, what do you think about releasing 1.5.8? -- Richard B. Kreckel <http://www.ginac.de/~kreckel/>