Hi, On 23.06.20 10:45, Alexey Sheplyakov wrote:
23.06.2020, 12:40, "Vladimir V. Kisil" <v.kisil@leeds.ac.uk>:
> On Tue, 23 Jun 2020 12:25:59 +0400, Alexey Sheplyakov <asheplyakov@yandex.ru> said:
ASh> The attached patch adds a test case.
I have missed why we need the declaration of the parser p in the code...
Actually it's not necessary. And the comment is a bit misleading. I've fixed both problems in a new version (attached).
So to avoid check/ becoming a mess, I propose renaming it to exam_collect_common_factor_zero.cpp in order to follow this nomenclature: exam: prefabricated tests (like pupils' exam) check: pore extensive randomized test vectors times: guess what! Also, the patch is missing mention in Makefile.am and CMakeList.txt. Oh, and: Thank you! -richy. -- Richard B. Kreckel <https://in.terlu.de/~kreckel/>