Hi! On 02/08/2011 07:11 PM, Alexei Sheplyakov wrote:
The patch works around msvc bug, *and* it helps CLN to avoid potential problems. The name `mulu32_high' is generic enough, and if someone ever writes
namespace mylibrary { extern "C" unsigned int mulu32_high; }
we'll get an obscure bug.
Okay, thanks. The patch can be applied when it is completed. But the question remains: which version of MSVC stopped accepting the current code? This ought to be documented.
3) I don't have access to MSVC. We've received many patches for CLN (and GiNaC, too) and applied most of them. Yet, it is still unclear to me what the status under MSVC is. Since patches keep coming in, I suppose that things are still not fully working.
I don't think this conclusion is correct. GCC-related patches keep coming in, too (to name few, commit 3c3275884, 44fa38df2, 352547eac, and so on). This doesn't mean that things are still not fully working, does it?
But browsing through the commit log it becomes apparant that the GCC version for which a certain patch has become necessary is always well documented. On the other hand, this level of detail is absent in patches for M$. This is a remarkable pattern. So, when somebody asks me what version of that M$-compiler it's known to work with I'm absolutely clueless and don't even see a practical way to find out. Well, that irritates me. That said, I'll make it a habit to ask about compiler details before accepting a patch. And, please, let's also try to better document these details in the INSTALL file. Bye! -richy. -- Richard B. Kreckel <http://www.ginac.de/~kreckel/>