Dear Alexei, Alexei Sheplyakov wrote:
New version of the patch is available at
http://theor.jinr.ru/~varg/0001-CL_INLINE-co-ISO-C-compliant-macros-for-sele...
It gets rid of MAYBE_INLINE completely. I don't post the patch here, since it's large enough (99k uncompressed). Sorry for that, but replacing MAYBE_INLINE in a gradual manner turned out to be surprisngly difficult, i.e. more difficult than rewriting them all.
Thanks a lot! I'm reviewing it and, so far, it looks good. One question. Your patch did not touch these: rbk@wallace:~/projects/cln-1.2/src$ grep -r inline_ . ./integer/elem/cl_I_minusp.cc:#define minusp inline_minusp ./integer/elem/cl_I_minusp.cc: return inline_minusp(x); ./integer/elem/cl_I_plusp.cc:#define minusp inline_minusp ./integer/elem/cl_I_plusp.cc:#define zerop inline_zerop ./integer/elem/cl_I_plusp.cc: if (inline_minusp(x)) ./integer/elem/cl_I_plusp.cc: elif (inline_zerop(x)) ./integer/elem/cl_I_zerop.cc:#define zerop inline_zerop ./integer/elem/cl_I_zerop.cc: return inline_zerop(x); ./rational/elem/cl_RA_denominator.cc:#define denominator inline_denominator ./rational/elem/cl_RA_denominator.cc: return inline_denominator(r); ./rational/elem/cl_RA_numerator.cc:#define numerator inline_numerator ./rational/elem/cl_RA_numerator.cc: return inline_numerator(r); ./rational/elem/cl_RA_plusp.cc:#define minusp inline_minusp ./rational/elem/cl_RA_plusp.cc:#define zerop inline_zerop ./rational/elem/cl_RA_plusp.cc: if (inline_minusp(x)) ./rational/elem/cl_RA_plusp.cc: elif (inline_zerop(x)) ./rational/elem/cl_RA_zerop.cc:#define zerop inline_zerop ./rational/elem/cl_RA_zerop.cc: return inline_zerop(x); Wouldn't it make sense to convert them to make use of your new inline scheme, too? -richy. -- Richard B. Kreckel <http://www.ginac.de/~kreckel/>