February 2018 - CLN-list

MinGW64 build
by Robert Szalai 05 Nov '19

05 Nov '19

Hi all, I've been trying to build CLN from windows 64, with some success. It compiles fine, but does not work. The problem is that WIN64 is LLP64, and not ILP64 as Linux. CLN uses long to store pointer data, but size_t or ssize_t should be used as it is guaranteed to be the size of the pointer everywhere. The attached patch was my attempt. Could somebody tell me where else should I look? Pointers are also encoding some metadata in the bits that are set to zero by alingnment, what is this data? There is also some hashing of pointers. Thanks, Robert

6 21

Question about compiler warning
by Jan Rheinländer 13 Mar '18

13 Mar '18

Hi, in integer/gcd/cl_I_gcd_aux2.cc there are the lines (starting at line 76): void partial_gcd (uintDD z1, uintDD z2, partial_gcd_result* erg) { var uintD x1 = 1; ... line 100: if (qx > (uintDD)(~x1)) { The compiler tells me that after taking the bitwise complement of x1, the (uintDD) cast will extend x1 by adding zeros, which is probably not the intention? See https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compi… Regards, Jan Rheinländer

3 4

win64 build
by Jan Rheinländer 24 Feb '18

24 Feb '18

Hi, I'm trying to create a win64 build of CLN. Most of the changes seem to involve replacing "unsigned long" with "uintptr_t" since "long" is 32bit in Win64. To make these changes useable for the community (by way of a git patch?), should I a) just go ahead and change b) put all the changes into a #if defined(_M_AMD64) <changed code> #else <original code> #endif I refer specifically to the "unsigned long" to "uintptr_t" changes, not to all changes in general. Is there any danger in doing this change on other platforms? Best regards, Jan Rheinländer

3 3